-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ASCII-145] Move apm status to pkg/status/apm
#21067
Conversation
Go Package Import DifferencesBaseline: 9e07eb9
|
da6b054
to
3e8f56f
Compare
pkg/status/apm
pkg/status/apm
pkg/status/apm
Bloop Bleep... Dogbot HereRegression Detector ResultsRun ID: a552b2cf-c8f2-4153-905a-23fdceef30fe ExplanationA regression test is an integrated performance test for Because a target's optimization goal performance in each experiment will vary somewhat each time it is run, we can only estimate mean differences in optimization goal relative to the baseline target. We express these differences as a percentage change relative to the baseline target, denoted "Δ mean %". These estimates are made to a precision that balances accuracy and cost control. We represent this precision as a 90.00% confidence interval denoted "Δ mean % CI": there is a 90.00% chance that the true value of "Δ mean %" is in that interval. We decide whether a change in performance is a "regression" -- a change worth investigating further -- if both of the following two criteria are true:
The table below, if present, lists those experiments that have experienced a statistically significant change in mean optimization goal performance between baseline and comparison SHAs with 90.00% confidence OR have been detected as newly erratic. Negative values of "Δ mean %" mean that baseline is faster, whereas positive values of "Δ mean %" mean that comparison is faster. Results that do not exhibit more than a ±5.00% change in their mean optimization goal are discarded. An experiment is erratic if its coefficient of variation is greater than 0.1. The abbreviated table will be omitted if no interesting change is observed. No interesting changes in experiment optimization goals with confidence ≥ 90.00% and |Δ mean %| ≥ 5.00%. Fine details of change detection per experiment.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🚀
<span class="stat_title">APM</span> | ||
<span class="stat_data">Loading...</span> | ||
<span class="stat_data"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🍰 way better
3e8f56f
to
ca13f55
Compare
880fb5a
to
3e90daf
Compare
- Handle communicating with the trace-agent in the status package - Update the GUI to rende the apmStats using the informatoin from the server rather than using AJAX
3e90daf
to
bbdb504
Compare
What does this PR do?
Following how the status package fetches the process agent status, we are changing how we fetch the APM status.
Rather than doing an extra call from the CLI
agent status
(Client), we fetch it directly from the agent backend (pkg/status
)That means that CLI no longer has to worry about fetching the APM status or any other status for any other agent process; the backend takes care of fetching everything for it and making the CLI code simpler.
As an added bonus, the GUI was using AJAX to replicate the CLI behaviour; since the GUI is using the
pkg/status
to fetch that information, we no longer have to maintain that JS code for the GUI. 🔥Context
Here is the PR that introduced the trace agent status #5235
Here is the PR that added the process agent status #10886
Results
Here is a screenshot of the GUI using the current branch
Here is the output of APM section of
agent status
Motivation
Additional Notes
Possible Drawbacks / Trade-offs
Describe how to test/QA your changes
Make sure the trace agent and the agent is running.
To enable the trace agent, add this to your configuration:
Once they are running we should validate that:
agent status
returns the correct informationagent launch-gui
Reviewer's Checklist
Triage
milestone is set.major_change
label if your change either has a major impact on the code base, is impacting multiple teams or is changing important well-established internals of the Agent. This label will be use during QA to make sure each team pay extra attention to the changed behavior. For any customer facing change use a releasenote.changelog/no-changelog
label has been applied.qa/skip-qa
label is not applied.team/..
label has been applied, indicating the team(s) that should QA this change.need-change/operator
andneed-change/helm
labels have been applied.k8s/<min-version>
label, indicating the lowest Kubernetes version compatible with this feature.